Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(global): Move from tempdir to tempfile: #1523

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

sylvestre
Copy link
Contributor

  • the crate has been deprecated

@rivy
Copy link
Member

rivy commented Jun 3, 2020

Deprecation of permanently available crates, is not, on its own, reason enough to upgrade when it breaks the project's MinRustV.

Does this otherwise solve a problem?

@sylvestre
Copy link
Contributor Author

Yeah, I don't think any project should depend on unmaintained code, esp as upstream merged tempdir into tempfile, which is maintained.

About the build issue, it is explained here:
rust-random/getrandom#15 (review)

Note that we are already depending on tempfile:

tempfile = "2.1.5"

so, having two libs doing the same thing in the same project isn't optimal :)

@Arcterus
Copy link
Collaborator

Arcterus commented Jun 8, 2020

Is this every instance of tempdir?

@sylvestre
Copy link
Contributor Author

yeah, afaik
I will rebase the patch

@Arcterus
Copy link
Collaborator

Arcterus commented Jun 8, 2020

Looks like you need to rebase again...

* the crate has been deprecated
@sylvestre
Copy link
Contributor Author

@Arcterus rebased and green!

@Arcterus Arcterus merged commit b7b347f into uutils:master Jun 9, 2020
@sylvestre sylvestre deleted the tempdir branch June 9, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants